ctubbsii commented on code in PR #368:
URL: https://github.com/apache/accumulo-website/pull/368#discussion_r1025988006
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
Review Comment:
I think these two can be combined with a small narrative:
```suggestion
* {% ghi 3077 %}, {% ghi 3079 %} Avoid filling OS file caches by setting the
`FSDataOutputStream.setDropBehind` flag when performing likely one-time
file
accesses, as with WAL files and major compaction input files. This should
allow
files that might benefit more from caching to stay in the cache longer.
```
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
+
+### Behavior Changes
+
+* {% ghi 3082 %} ScanServers can now scan offline tables. The AccumuloClient
will no longer
+ throw a TableOfflineException when creating a Scanner or BatchScanner
against an offline table.
+ Instead, an error will be thrown on the call to iterator().
Review Comment:
```suggestion
Instead, an error will be thrown on the call to iterator() if it can't be
scanned because it is offline.
```
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
+
+### Behavior Changes
+
+* {% ghi 3082 %} ScanServers can now scan offline tables. The AccumuloClient
will no longer
+ throw a TableOfflineException when creating a Scanner or BatchScanner
against an offline table.
+ Instead, an error will be thrown on the call to iterator().
+
+### Bug Fixes
+
+* {% ghi 3059 %} Remove stale compactions from CompactionCoordinator internal
structure
+* {% ghi 3057 %} Modified Monitor to direct DataTable errors to console
+* {% ghi 3053 %} Reduce amount of thread pool logging
+* {% ghi 3048 %} Shorten time strings in Monitor
Review Comment:
```suggestion
* {% ghi 3048 %} Output time strings on the monitor using the correct user
locale (also made them more concise)
```
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
+
+### Behavior Changes
+
+* {% ghi 3082 %} ScanServers can now scan offline tables. The AccumuloClient
will no longer
+ throw a TableOfflineException when creating a Scanner or BatchScanner
against an offline table.
+ Instead, an error will be thrown on the call to iterator().
+
+### Bug Fixes
+
+* {% ghi 3059 %} Remove stale compactions from CompactionCoordinator internal
structure
+* {% ghi 3057 %} Modified Monitor to direct DataTable errors to console
+* {% ghi 3053 %} Reduce amount of thread pool logging
Review Comment:
Is this actually a bug fix? Or just a improvement? It's in the bug fix
section, but I don't think that's correct. If it was a bug, we should briefly
explain the user impact. If it's just a nice improvement, it can probably be
combined into a succinct narrative with 3023 in the minor improvements section
above.
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
+
+### Behavior Changes
+
+* {% ghi 3082 %} ScanServers can now scan offline tables. The AccumuloClient
will no longer
+ throw a TableOfflineException when creating a Scanner or BatchScanner
against an offline table.
+ Instead, an error will be thrown on the call to iterator().
+
+### Bug Fixes
+
+* {% ghi 3059 %} Remove stale compactions from CompactionCoordinator internal
structure
Review Comment:
The description here could clarify what bug was fixed that the user might
have encountered (user impact narrative), rather than simply describing the
patch we applied. I'm not super familiar with the user impact to know what to
suggest.
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
Review Comment:
You don't need to include this. The `draft: true` front matter does this
automatically.
```suggestion
```
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
Review Comment:
Just clarifying that the reduction is because it was excessive and useless,
and we didn't just reduce the amount of potentially useful logs.
```suggestion
* {% ghi 3023 %} Prevent excessive logging when an ExternalCompaction is
cancelled for cause
```
##########
_posts/release/2022-12-01-accumulo-2.1.1.md:
##########
@@ -0,0 +1,50 @@
+---
+title: Apache Accumulo 2.1.1
+sortableversion: '02.01.01'
+LTM: true
+draft: true
+---
+
+** DRAFT RELEASE NOTES **
+
+## About
+
+Apache Accumulo 2.1.1 is a patch release of the 2.1.0 LTM line.
+
+### Major Improvements
+
+### Minor Improvements
+
+* {% ghi 3077 %} Call FSDataOutputStream.setDropBehind when reading and
writing WAL files
+* {% ghi 3079 %} Call FSDataOutputStream.setDropBehind on major compaction
input files
+* {% ghi 3023 %} Reduced the amount of logging when an ExternalCompaction is
cancelled for cause
+
+### Behavior Changes
+
+* {% ghi 3082 %} ScanServers can now scan offline tables. The AccumuloClient
will no longer
+ throw a TableOfflineException when creating a Scanner or BatchScanner
against an offline table.
+ Instead, an error will be thrown on the call to iterator().
+
+### Bug Fixes
+
+* {% ghi 3059 %} Remove stale compactions from CompactionCoordinator internal
structure
+* {% ghi 3057 %} Modified Monitor to direct DataTable errors to console
Review Comment:
I don't think this one was a bug either... just a very slightly improved
user experience with the monitor under some edge cases when the cluster isn't
available. It might not even be worth bothering to mention, except the list of
things for this patch release is pretty small, so we're not really risking
losing the reader's attention by including it, I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
