ctubbsii commented on issue #3086: URL: https://github.com/apache/accumulo/issues/3086#issuecomment-1323053172
One of the first tickets I worked on when the project went open source was https://issues.apache.org/jira/browse/ACCUMULO-756. That never got merged, but I think it can/should be revisited. It would make it easier to put the thrift stuff in its own project. However, that's a much bigger task than what's being discussed here, and even that doesn't solve the problem we're discussing much, because the changes that prompted this discussion, as well as many Thrift changes involving generated code changes, are changes where we need to change the RPC layer to support some feature on top, so both layers are changing simultaneously. I share the concerns about raising the barrier for new folks. Requiring docker instead of thrift isn't much better. I'm not entirely opposed to dropping the generated code from the source tree and just always activate the thrift profile, so it is generated each build, but I'd lean towards just keeping the status quo as my first choice. My second choice would be to do the .gitattributes thing and just deal with the generated code being squashed into the same commits as the changed code that generated it, as proposed here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
