dlmarion commented on code in PR #3090:
URL: https://github.com/apache/accumulo/pull/3090#discussion_r1029264662
##########
core/src/main/java/org/apache/accumulo/core/data/Mutation.java:
##########
@@ -1507,6 +1507,7 @@ public int size() {
* the peer to add
* @since 1.7.0
*/
+ @Deprecated(since = "2.1.1")
Review Comment:
> I'd like more opinions
[SemVer](https://semver.org/spec/v2.0.0#spec-item-7) says that the minor
version "MUST be incremented if any public API functionality is marked as
deprecated." The SemVer
[FAQ](https://semver.org/spec/v2.0.0#how-should-i-handle-deprecating-functionality)
about deprecation says that you should do two things when you deprecate part
of the public API, "(1) update your documentation to let users know about the
change, (2) issue a new minor release with the deprecation in place."
Based on an earlier conversation I believe we are planning on adding a
"Deprecated Items" (or similar) section to the top of the 2.1.0 release notes.
We could also state in that section that we missed a few methods in the public
API and they will be fixed in a patch release. #2335 already deprecated other
user facing replication related code (ReplicationOperations, Property.java). As
users compile and test against 2.1.0 there will be visible signs that
replication related items are deprecated via deprecation annotation warnings
for ReplicationOperations and printed warnings in the server logs for the
replication properties. With the changes in this paragraph, I believe that we
have satisfied 1 and 2 from the FAQ.
The SemVer FAQ also contains
[this](https://semver.org/spec/v2.0.0#what-if-i-inadvertently-alter-the-public-api-in-a-way-that-is-not-compliant-with-the-version-number-change-ie-the-code-incorrectly-introduces-a-major-breaking-change-in-a-patch-release).
Users of the replication feature should be well aware that the feature is
deprecated without having these deprecation annotations. I think it's fine to
put it in the patch release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
