dlmarion commented on PR #3093: URL: https://github.com/apache/accumulo/pull/3093#issuecomment-1325388266
@ctubbsii - I'm thinking that we don't need to move the Thrift generated code to another repo. I think that if we trust what Thrift generates as being correct (which is basically what we do now), then we can: 1. use the `.gitattributes` to make it easier to review changes that involve modifications to the Thrift IDL files 2. not worry about potentially malicious changes to the Thrift generated code because it's generated automatically by the build to match the IDL, so the tests are always using the latest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
