cshannon commented on PR #3134: URL: https://github.com/apache/accumulo/pull/3134#issuecomment-1356329348
For the testing I went ahead and marked the integration test as SunnyDay but I can take that off if we don't want to make those tests take longer. The test seems to take about 40-45 seconds to test the max frame size against the different Thrift configurations. Also note I added a test for all Thrift types except for SASL as SASL is a giant pain to setup and the main issue was when non blocking server is used which is covered by the tests and is `ThriftServerType.CUSTOM_HS_HA `(default) and `ThriftServerType.THREADPOOL`. Also a test isn't really necessary anyways when using SSL or SASL as both SSL and SASL just use `ThriftUtil.transportFactory()` to create the transport factory and that utility uses our default factory which sets the length to `Integer.MAX_VALUE` and isn't configurable as it doesn't read the max message size property. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
