ctubbsii commented on code in PR #3141:
URL: https://github.com/apache/accumulo/pull/3141#discussion_r1063841686
##########
server/base/src/main/java/org/apache/accumulo/server/conf/ServerConfigurationFactory.java:
##########
@@ -129,7 +129,7 @@ public NamespaceConfiguration
getNamespaceConfiguration(NamespaceId namespaceId)
context.getPropStore().registerAsListener(NamespacePropKey.of(context,
namespaceId),
deleteWatcher);
var conf = new NamespaceConfiguration(context, namespaceId,
getSystemConfiguration());
- ConfigCheckUtil.validate(conf);
+ ConfigCheckUtil.validate(conf, namespaceId.toString());
Review Comment:
Since these are strings, I think I would have preferred something like:
```java
ConfigCheckUtil.validate(conf, "Namespace id: " + namespaceId);
```
So we know it's a namespace and not a table ID. Same with the table IDs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
