EdColeman commented on PR #3161: URL: https://github.com/apache/accumulo/pull/3161#issuecomment-1385760975
@dlmarion - I do not understand your response. The previous GC code gets flagged by findbugs at the next compliance level above the level that we currently run. The code change that I proposed fixed that warning. I don't think you changed the instantiation code from the original - so I think that your code will also have the same warning / issue. If you took my initialization and moved the GC instantiation into the context I think it would resolve the findbugs warning / potential synchronization issue. Because you also renamed the GC, most of my PR is OBE, but the initialization change should still be valid. Or maybe another approach? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
