EdColeman opened a new pull request, #3166: URL: https://github.com/apache/accumulo/pull/3166
- rename variable in ScannerOptions from timeOut to scanTimeOut - fixes possible bug where input variable (timeout) was using the instance value for checks - rename variable in IsolatedScanner from timeOut to iteratorTimeout - fix some flagged grammar suggestions. In IsolatedScanner, the two timeouts are confusing and it could be an error that there are two values when one was intended, but I preserved current behavior. There are other code style issues that can be addressed in these files, but I didn't want those changes to hide the timeout renaming with even more unrelated changes. I ran into the timeout naming while trying to look at synchronization warnings and having timeout, and timeOut available as valid code completion options made it harder to reason about the correct value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
