dlmarion commented on code in PR #3168:
URL: https://github.com/apache/accumulo/pull/3168#discussion_r1090792710
##########
core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocatorImpl.java:
##########
@@ -330,8 +348,16 @@ else if (!lookupFailed)
tabletLocations.add(tl);
}
- for (TabletLocation tl2 : tabletLocations) {
- TabletLocatorImpl.addRange(binnedRanges, tl2.tablet_location,
tl2.tablet_extent, range);
+ // Ensure the extents found are non overlapping and have no holes. When
reading some extents
+ // from the cache and other from the metadata table in the loop above we
may end up with
+ // non-contiguous extents. This can happen when a subset of exents are
placed in the cache and
+ // then after that merges and splits happen.
+ if (isContiguous(tabletLocations)) {
Review Comment:
Ok, you are right, I missed a bracket, so I thought that this was outside of
loop `l1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
