dlmarion commented on code in PR #3187:
URL: https://github.com/apache/accumulo/pull/3187#discussion_r1097510205
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -931,9 +934,7 @@ public enum Property {
"The sampling percentage to use for replication traces"),
REPLICATION_RPC_TIMEOUT("replication.rpc.timeout", "2m",
PropertyType.TIMEDURATION,
"Amount of time for a single replication RPC call to last before failing"
- + " the attempt. See replication.work.attempts."),
-
- ;
+ + " the attempt. See replication.work.attempts."),;
Review Comment:
Should be able to remove trailing comma before the semi-colon.
##########
core/src/main/java/org/apache/accumulo/core/client/impl/ThriftScanner.java:
##########
@@ -116,7 +116,10 @@ public static boolean getBatchFromServer(ClientContext
context, Range range, Key
Constants.SCANNER_DEFAULT_READAHEAD_THRESHOLD, null, batchTimeOut,
classLoaderContext);
TabletType ttype = TabletType.type(extent);
- boolean waitForWrites =
!serversWaitedForWrites.get(ttype).contains(server);
+ boolean waitForWrites = false;
+ if
(context.getConfiguration().getBoolean(Property.TSERV_SCAN_INITIAL_WAIT_ENABLED))
{
Review Comment:
It should only be configurable where TabletType == TabletType.USER.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
