ctubbsii commented on PR #3175: URL: https://github.com/apache/accumulo/pull/3175#issuecomment-1419966573
If GitHub has to show `...` for the first line of a commit message, it is a good hint that it's far too long. We've had several very long "subject" line portions in our git logs. This was the most recent one I noticed (but not the worst). It would be a good goal to keep very brief subject lines in the git logs, and put more details in the body. For example, here's my attempt to polish up this commit message's subject line (solely as an example for how it could be done for future commits): ```diff -Increased number of locks in SynchronousLoadingBlockCache and set them to be fair (#3175) +Improve lock behavior in SynchronousLoadingBlockCache (#3175) ``` The body already describes what the improvements are (increasing the count and making them fair), so we don't need those details in the subject line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
