ctubbsii commented on code in PR #3192:
URL: https://github.com/apache/accumulo/pull/3192#discussion_r1103106608
##########
assemble/bin/accumulo:
##########
@@ -89,4 +89,21 @@ function main() {
exec "${JAVA[@]}" "${JAVA_OPTS[@]}" org.apache.accumulo.start.Main "$@"
}
+args=("$@")
+
+if [ -n "$ACCUMULO_BIND_ADDR" ]; then
+ args+=("-o")
+ args+=("general.process.bind.addr=${env:ACCUMULO_BIND_ADDR}")
+fi
+
+if [ -n "$ACCUMULO_COMPACTOR_QUEUE" ]; then
+ args+=("-o")
+ args+=("compactor.queue=${env:ACCUMULO_COMPACTOR_QUEUE}")
+fi
+
+if [ -n "$ACCUMULO_SSERVER_GROUP" ]; then
+ args+=("-o")
+ args+=("sserver.group=${env:ACCUMULO_SSERVER_GROUP}")
+fi
+
main "$@"
Review Comment:
Gotcha. In any case, I don't think we should be hard-coding these options
into `bin/accumulo` or creating env variables as proxies for them at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
