EdColeman commented on code in PR #3161:
URL: https://github.com/apache/accumulo/pull/3161#discussion_r1104981967
##########
server/base/src/main/java/org/apache/accumulo/server/compaction/FileCompactor.java:
##########
@@ -429,7 +429,13 @@ private void compactLocalityGroup(String lgName,
Set<ByteSequence> columnFamilie
} else {
metrics.incrementMajCPause();
}
- Thread.sleep(500);
+ try {
+ Thread.sleep(500);
+ } catch (InterruptedException e) {
+ Thread.interrupted();
Review Comment:
```suggestion
Thread.currentThread.interrupt();
```
##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/TabletBase.java:
##########
@@ -233,20 +233,19 @@ public Tablet.LookupResult lookup(List<Range> ranges,
List<KVEntry> results,
Batch nextBatch(SortedKeyValueIterator<Key,Value> iter, Range range,
ScanParameters scanParams)
throws IOException {
- try {
- while (context.getLowMemoryDetector().isRunningLowOnMemory(context,
DetectionScope.SCAN,
- () -> {
- return isUserTable;
- }, () -> {
- log.info("Not starting next batch because low on memory, extent:
{}", extent);
- server.getScanMetrics().incrementScanPausedForLowMemory();
- Thread.sleep(500);
- })) {}
- } catch (InterruptedException e) {
- // Reset the interrupt state on this thread
- Thread.interrupted();
- throw new IOException("Pause for low memory interrupted", e);
- }
+ while (context.getLowMemoryDetector().isRunningLowOnMemory(context,
DetectionScope.SCAN, () -> {
+ return isUserTable;
+ }, () -> {
+ log.info("Not starting next batch because low on memory, extent: {}",
extent);
+ server.getScanMetrics().incrementScanPausedForLowMemory();
+ try {
+ Thread.sleep(500);
+ } catch (InterruptedException e) {
+ Thread.interrupted();
Review Comment:
```suggestion
Thread.currentThread.interrupt();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
