cshannon commented on PR #3136: URL: https://github.com/apache/accumulo/pull/3136#issuecomment-1435142227
I think this is ready to go, I pushed more updates including removing the broken ClassLoaderIT that was failing as that no loner applies (it only was there to test the VFS reloading) and I also removed the no longer needed code from the Main start class that also only applied to VFS. I spent a bunch of time testing to make sure the VFS classloader worked with the changes by using the [accumulo-classloaders](https://github.com/apache/accumulo-classloaders) project and seems to be working well. I used these instructions https://github.com/apache/accumulo-classloaders/blob/main/modules/vfs-class-loader/TESTING.md and I tested against Uno. I tested both Setting a system classloader as well as using a context using the new [instructions](https://github.com/apache/accumulo-classloaders/blob/main/modules/vfs-class-loader/TESTING.md#setting-scan-context-on-table-new) and properties. A couple changes will be needed to the documentation to the instructions page (property rename for the table context, need to mention to make sure to add the commons VFS jar since it was removed from 3.0.0) otherwise the testing instructions are pretty much up to date. I can submit a small PR with the changes probably tomorrow. I kicked off another full IT so this should be ready to merge if that passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
