ctubbsii commented on code in PR #3229:
URL: https://github.com/apache/accumulo/pull/3229#discussion_r1128903483
##########
core/src/main/java/org/apache/accumulo/core/spi/scan/ScanDispatcher.java:
##########
@@ -115,13 +90,7 @@ public interface DispatchParameters {
*
* @since 2.1.0
*/
-
default ScanDispatch dispatch(DispatchParameters params) {
- String executor = dispatch((DispatchParmaters) params);
- if
(executor.equals(DefaultScanDispatch.DEFAULT_SCAN_DISPATCH.getExecutorName())) {
- return DefaultScanDispatch.DEFAULT_SCAN_DISPATCH;
- }
-
- return ScanDispatch.builder().setExecutorName(executor).build();
+ return DefaultScanDispatch.DEFAULT_SCAN_DISPATCH;
Review Comment:
I would like feedback on this particular change, because I'm not sure if
this should be the right default implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
