dlmarion commented on code in PR #3230:
URL: https://github.com/apache/accumulo/pull/3230#discussion_r1129948088
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/PreUpgradeValidation.java:
##########
@@ -117,4 +141,114 @@ private void fail(Exception e) {
System.exit(1);
}
+ private void validateTableLocks(final ServerContext context) {
+
+ final ZooReaderWriter zrw = context.getZooReaderWriter();
+ final ZooKeeper zk = zrw.getZooKeeper();
+ final String rootPath = context.getZooKeeperRoot();
+ final String tserverLockRoot = rootPath + Constants.ZTSERVERS;
+
+ log.debug("Looking for locks that may be from previous version in path:
{}", tserverLockRoot);
+
+ AtomicInteger errorCount = new AtomicInteger(0);
+
+ List<Pair<HostAndPort,ServiceLock.ServiceLockPath>> hostsWithLocks =
+ gatherLocks(zk, tserverLockRoot);
+
+ // try a thrift call to the hosts - hosts running previous versions will
fail the call
+ ThreadPoolExecutor lockCheckPool =
ThreadPools.getServerThreadPools().createThreadPool(8, 32,
+ 10, MINUTES, "update-lock-check", false);
+ try {
+ Future<?> f = lockCheckPool.submit(() ->
hostsWithLocks.parallelStream().forEach(p -> {
Review Comment:
This appears that it will submit `1` task to the `lockCheckPool` and that
task will then use the common `ForkJoinPool` to check the hosts in parallel. Is
that right?
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/PreUpgradeValidation.java:
##########
@@ -117,4 +141,114 @@ private void fail(Exception e) {
System.exit(1);
}
+ private void validateTableLocks(final ServerContext context) {
+
+ final ZooReaderWriter zrw = context.getZooReaderWriter();
+ final ZooKeeper zk = zrw.getZooKeeper();
+ final String rootPath = context.getZooKeeperRoot();
+ final String tserverLockRoot = rootPath + Constants.ZTSERVERS;
+
+ log.debug("Looking for locks that may be from previous version in path:
{}", tserverLockRoot);
+
+ AtomicInteger errorCount = new AtomicInteger(0);
+
+ List<Pair<HostAndPort,ServiceLock.ServiceLockPath>> hostsWithLocks =
+ gatherLocks(zk, tserverLockRoot);
+
+ // try a thrift call to the hosts - hosts running previous versions will
fail the call
+ ThreadPoolExecutor lockCheckPool =
ThreadPools.getServerThreadPools().createThreadPool(8, 32,
Review Comment:
As we discussed, I think you should just use the default ForkJoinPool here.
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/PreUpgradeValidation.java:
##########
@@ -117,4 +141,114 @@ private void fail(Exception e) {
System.exit(1);
}
+ private void validateTableLocks(final ServerContext context) {
+
+ final ZooReaderWriter zrw = context.getZooReaderWriter();
+ final ZooKeeper zk = zrw.getZooKeeper();
+ final String rootPath = context.getZooKeeperRoot();
+ final String tserverLockRoot = rootPath + Constants.ZTSERVERS;
+
+ log.debug("Looking for locks that may be from previous version in path:
{}", tserverLockRoot);
+
+ AtomicInteger errorCount = new AtomicInteger(0);
+
+ List<Pair<HostAndPort,ServiceLock.ServiceLockPath>> hostsWithLocks =
Review Comment:
Suggest checking for all server types. It's possible even another manager
(maybe secondary) with old software could be running.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
