keith-turner commented on code in PR #3271:
URL: https://github.com/apache/accumulo/pull/3271#discussion_r1155962011
##########
server/base/src/test/java/org/apache/accumulo/server/client/BulkImporterTest.java:
##########
@@ -147,25 +148,25 @@ public void testFindOverlappingTablets() throws Exception
{
List<TabletLocation> overlaps =
BulkImporter.findOverlappingTablets(context, vm, locator, new
Path(file), null, null, cs);
assertEquals(5, overlaps.size());
- Collections.sort(overlaps);
- assertEquals(new KeyExtent(tableId, new Text("a"), null),
overlaps.get(0).tablet_extent);
+ Collections.sort(overlaps, Comparator.comparing(tl -> tl.getExtent()));
Review Comment:
Yeah this test was the only thing that used the compare to functionality.
So I thought it would be simpler from a maintenance stand point to move it to
the test. Also the test only needs to order by extent, it does not need any
secondary comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
