keith-turner commented on code in PR #3274:
URL: https://github.com/apache/accumulo/pull/3274#discussion_r1157644809
##########
core/src/main/java/org/apache/accumulo/core/metadata/schema/Ample.java:
##########
@@ -243,6 +256,10 @@ public interface TabletsMutator extends AutoCloseable {
* Interface for changing a tablets persistent data.
*/
interface TabletMutator {
+ TabletMutator updateLastForAssignmentMode(KeyExtent extent,
TServerInstance location);
Review Comment:
I think of tablet mutator as something the helps build a mutation for
updating the Accumulo metadata table. The implementation of this method reads
the tablets while building the mutation, which could have race conditions
depending on the context. These potential race conditions and the fact that it
read the tablet need to be documented here or the more complicated logic of
read,modify,update code should be located elsewhere and TabletMutator only does
the write portion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
