cshannon commented on issue #3282: URL: https://github.com/apache/accumulo/issues/3282#issuecomment-1500901715
I looked at ScanServer and it uses the same [serverStopRequested](https://github.com/apache/accumulo/blob/main/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java#L373) variable but doesn't have the `shutdownComplete` flag. On shutdown it just tries to close stuff in a finally block but I assume has the same behavior as TabletServer where the finally doesn't really get executed since halt will just stop the JVM. As a test locally I took out the `shutdownComplete` flag and loop to see what would happen and none of the code that is after where the loop was is executed as the JVM shutsdown too fast when halt is called so doesn't seem like it provides much value even if we got rid of the broken loop. Also, I am wondering why we are using halt and not exit as halt won't ever call shutdown hooks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
