dlmarion commented on code in PR #3294:
URL: https://github.com/apache/accumulo/pull/3294#discussion_r1168705292
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java:
##########
@@ -269,18 +273,28 @@ protected Mutation getMutation() {
}
@Override
- public T putOnDemand() {
- mutation.put(OnDemandAssignmentStateColumnFamily.STR_NAME, "", "");
+ public T setHostingGoal(TabletHostingGoal goal) {
+ mutation.put(HostingColumnFamily.GOAL_COLUMN.getColumnFamily(),
+ HostingColumnFamily.GOAL_COLUMN.getColumnQualifier(),
TabletHostingGoalUtil.toValue(goal));
+ return getThis();
+ }
+
+ @Override
+ public T setHostingRequested() {
+ mutation.put(HostingColumnFamily.REQUESTED_COLUMN.getColumnFamily(),
+ HostingColumnFamily.REQUESTED_COLUMN.getColumnQualifier(),
EMPTY_VALUE);
Review Comment:
Suggestion applied in cd223b6
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java:
##########
@@ -269,18 +273,28 @@ protected Mutation getMutation() {
}
@Override
- public T putOnDemand() {
- mutation.put(OnDemandAssignmentStateColumnFamily.STR_NAME, "", "");
+ public T setHostingGoal(TabletHostingGoal goal) {
+ mutation.put(HostingColumnFamily.GOAL_COLUMN.getColumnFamily(),
+ HostingColumnFamily.GOAL_COLUMN.getColumnQualifier(),
TabletHostingGoalUtil.toValue(goal));
+ return getThis();
+ }
+
+ @Override
+ public T setHostingRequested() {
+ mutation.put(HostingColumnFamily.REQUESTED_COLUMN.getColumnFamily(),
+ HostingColumnFamily.REQUESTED_COLUMN.getColumnQualifier(),
EMPTY_VALUE);
return getThis();
}
@Override
- public T deleteOnDemand() {
- mutation.putDelete(OnDemandAssignmentStateColumnFamily.STR_NAME, "");
+ public T deleteHostingRequested() {
+ mutation.putDelete(HostingColumnFamily.REQUESTED_COLUMN.getColumnFamily(),
+ HostingColumnFamily.REQUESTED_COLUMN.getColumnQualifier());
Review Comment:
Suggestion applied in cd223b6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
