keith-turner commented on code in PR #3319:
URL: https://github.com/apache/accumulo/pull/3319#discussion_r1171430501
##########
core/src/main/thrift/client.thrift:
##########
@@ -46,13 +46,13 @@ enum TableOperationExceptionType {
NOTFOUND
OFFLINE
BULK_BAD_INPUT_DIRECTORY
- BULK_BAD_ERROR_DIRECTORY
Review Comment:
I took a quick look i the thrift code and it seems like it may use intergers
for the enums on the wire, so the obsolete things makes sense for that reason.
If it used the enum names on the wire it would not matter so much.
##########
core/src/main/thrift/client.thrift:
##########
@@ -46,13 +46,13 @@ enum TableOperationExceptionType {
NOTFOUND
OFFLINE
BULK_BAD_INPUT_DIRECTORY
- BULK_BAD_ERROR_DIRECTORY
Review Comment:
I took a quick look i the thrift code and it seems like it may use integers
for the enums on the wire, so the obsolete things makes sense for that reason.
If it used the enum names on the wire it would not matter so much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
