ctubbsii commented on code in PR #384: URL: https://github.com/apache/accumulo-website/pull/384#discussion_r1177332360
########## Dockerfile: ########## @@ -0,0 +1,40 @@ +# This Dockerfile builds an ruby environment for jekyll that empowers +# making updates to the accumulo website without requiring the dev +# to maintain a local ruby development environment. + +FROM ruby:2.7.8-slim-bullseye as base + +RUN apt-get update && apt-get install -y --no-install-recommends \ + build-essential \ + git \ + curl \ + && rm -rf /var/lib/apt/lists/* + +WORKDIR /site + + +# Copy over the Gemfiles so that all build dependencies are installed +# during build vs at runtime. + +COPY Gemfile /site/Gemfile +COPY Gemfile.lock /site/Gemfile.lock Review Comment: > always run in a docker image I think part of my earlier confusion comes from your loose interchange of "image" and "container". I think I know enough to parse those out without trouble now. But, for clarity, I don't think it makes sense to say anything is running in an image. I think if we were to be precise, then things run inside containers (as opposed to images), and containers are launched/created from an image. I think of images as just snapshots of a particular container's (stopped) state, from which another container can be launched. The build stage, therefore, just seems to be a starting up a container with one base image as input, and a new (possibly incremental CoW) image as output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
