cshannon commented on issue #3346: URL: https://github.com/apache/accumulo/issues/3346#issuecomment-1528823989
It looks like the original version of this was first merged in #2320 and was to fix #2301. There were a couple more modifications by #2524 and #2583 So there of course is the question of why the scanner is closed (as @ivakegg said, possible HDFS issues reading RFiles) but at the very least we need to catch exceptions here because as shown uncaught runtime exceptions will bubble up and kill the task and the server. I think that simply catching exceptions and logging an error is probably fine here and I don't necessarily think we need to do anything else because if it's something like HDFS issues as alluded do with the scans than we really can't handle that other than catch the errors and not fall over. I also don't think we need to worry about an exponential backoff or anything and can just let the task retry normally the next run. The default health check period is every 30 minutes so it's certainly not a rapid check that needs to be backed off (at least unless someone decided to speed it up with the property [here](https://github.com/apache/accumulo/blob/ba472d6e24daa8f0014a22cabace3061f5d46413/core/src/main/java/org/apache/accumulo/core/conf/Property.java#L625)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
