dlmarion commented on code in PR #3380:
URL: https://github.com/apache/accumulo/pull/3380#discussion_r1186324616


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java:
##########
@@ -274,11 +281,13 @@ private void binRanges(TabletLocator tabletLocator, 
List<Range> ranges,
               failures.size());
         }
 
+        retry.useRetry();
         try {
-          Thread.sleep(100);
-        } catch (InterruptedException e) {
-          throw new RuntimeException(e);
+          retry.waitForNextAttempt(log, "binRanges retry failures");
+        } catch (InterruptedException e1) {
+          log.debug("Retry interrupted", e1);

Review Comment:
   copy / paste issue. Fixed in 65b79ae



##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReaderIterator.java:
##########
@@ -248,6 +251,10 @@ private void binRanges(TabletLocator tabletLocator, 
List<Range> ranges,
 
     int lastFailureSize = Integer.MAX_VALUE;
 
+    Retry retry = Retry.builder().infiniteRetries().retryAfter(100, 
MILLISECONDS)
+        .incrementBy(100, MILLISECONDS).maxWait(1, SECONDS).backOffFactor(1.07)

Review Comment:
   Changed in 65b79ae



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to