ctubbsii commented on issue #3348: URL: https://github.com/apache/accumulo/issues/3348#issuecomment-1541184199
> So do you think it's appropriate to just use Long.MAX_VALUE ... My point was that the appropriate solution might be a case-by-case basis sort of thing. I'm not sure what value would be appropriate without digging in deep to figure out all the places where it's used. > We could of course just handle a returned negative in both places but it still seems like the simplest thing is to have that method just return Long.MAX_VALUE as the computed range length if it detects an overflow/negative otherwise everytime we call the method we have to handle a potential negative returned which could lead to inconsistencies. I think it was pointed out previously that the overflow could occur in some of the calling code anyway, so fixing in this method alone is not sufficient, and may be redundant to the fix in the calling code. My main point before was that the behavior of this method isn't important, because it's not public API, so long as the calling code handles it correctly, on a case-by-case basis. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
