ctubbsii commented on code in PR #3400:
URL: https://github.com/apache/accumulo/pull/3400#discussion_r1196766247
##########
core/src/main/java/org/apache/accumulo/core/spi/common/ContextClassLoaderFactory.java:
##########
@@ -57,4 +57,11 @@ public interface ContextClassLoaderFactory {
*/
ClassLoader getClassLoader(String contextName);
+ /**
+ * Pass the service environment to allow for additional class loader
configuration
+ *
+ * @param env the class loader environment
+ */
+ default void setEnvironment(ContextClassLoaderEnvironment env) {}
Review Comment:
@keith-turner I see it. I don't mind the name to follow the same pattern. If
we're using a level of indirection to get the configuration, do you think it
would be better if InitParameters return a ContextClassLoaderEnvironment which
returns the ServiceEnvironment.Configuration, or should it just replace the
environment, and return the ServiceEnvironment.Configuration? Or should it
return a `Supplier<ServiceEnvironment.Configuration`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
