keith-turner commented on code in PR #3409:
URL: https://github.com/apache/accumulo/pull/3409#discussion_r1202891676
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/ZooTabletStateStore.java:
##########
@@ -42,16 +39,14 @@ class ZooTabletStateStore extends AbstractTabletStateStore
implements TabletStat
private static final Logger log =
LoggerFactory.getLogger(ZooTabletStateStore.class);
private final Ample ample;
- private final ClientContext context;
ZooTabletStateStore(ClientContext context) {
super(context);
- this.context = context;
this.ample = context.getAmple();
}
@Override
- public ClosableIterator<TabletLocationState> iterator() {
+ public ClosableIterator<ManagerTabletInfo> iterator() {
Review Comment:
ok, so if this code always returns NEEDS_LOCATION_UPDATE for the root tablet
then the manager code will look at the tablets locations and the live tserver
set and see if there is actually anything to do? If that is the case then its
fine the way it was, maybe add a comment about why NEEDS_LOCATION_UPDATE is
always returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
