DomGarguilo commented on code in PR #3431:
URL: https://github.com/apache/accumulo/pull/3431#discussion_r1206979540
##########
server/manager/src/main/java/org/apache/accumulo/manager/FateServiceHandler.java:
##########
@@ -740,6 +740,23 @@ public void executeFateOperation(TInfo tinfo, TCredentials
c, long opid, FateOpe
.map(ByteBufferUtil::toText).collect(Collectors.toCollection(TreeSet::new));
KeyExtent extent = new KeyExtent(tableId, endRow, prevEndRow);
+
+ if (splits.stream()
+ .anyMatch(split -> !extent.contains(split) ||
split.equals(extent.endRow()))) {
+ throw new ThriftTableOperationException(tableId.canonical(), null,
tableOp,
+ TableOperationExceptionType.OTHER,
+ "Split is outside bounds of tablet or equal to the tablets
endrow");
+ }
Review Comment:
I did just realize that we may not want to do this if the split is very
large it might not be helpful to include in the logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
