keith-turner commented on code in PR #3439:
URL: https://github.com/apache/accumulo/pull/3439#discussion_r1211770387


##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementIterator.java:
##########
@@ -214,8 +214,12 @@ private static Map<TableId,MergeInfo> parseMerges(final 
String merges) {
 
   private static boolean shouldReturnDueToSplit(final TabletMetadata tm,
       final long splitThreshold) {
-    return tm.getFilesMap().values().stream().map(DataFileValue::getSize)
-        .collect(Collectors.summarizingLong(Long::longValue)).getSum() > 
splitThreshold;
+    final long sumOfFileSizes =

Review Comment:
   > It might need to be returned so that it can be unassigned?
   
   Yeah maybe for merge. For the case where a tablet has an opid, it should 
only have an opid if there is no location.  Opid and location should be 
mutually exclusive like current and future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to