dlmarion commented on code in PR #3436:
URL: https://github.com/apache/accumulo/pull/3436#discussion_r1212201644
##########
server/gc/src/test/java/org/apache/accumulo/gc/SimpleGarbageCollectorTest.java:
##########
@@ -132,7 +134,7 @@ public void testMoveToTrash_UsingTrash_VolMgrFailure()
throws Exception {
@Test
public void testMoveToTrash_NotUsingTrash() throws Exception {
- systemConfig.set(Property.GC_TRASH_IGNORE.getKey(), "true");
+ systemConfig.set(p.getKey(), "true");
Review Comment:
Implemented in 2aa689f
##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -463,11 +463,15 @@ boolean inSafeMode() {
boolean moveToTrash(Path path) throws IOException {
final VolumeManager fs = context.getVolumeManager();
if (!isUsingTrash()) {
+ log.trace("Accumulo Trash is disabled.");
return false;
}
try {
- return fs.moveToTrash(path);
+ boolean success = fs.moveToTrash(path);
+ log.trace("Accumulo Trash enabled, moving to trash succeeded?: {}",
success);
+ return success;
} catch (FileNotFoundException ex) {
+ log.error("Error moving to trash", ex);
Review Comment:
Implemented in 2aa689f
##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -463,11 +463,15 @@ boolean inSafeMode() {
boolean moveToTrash(Path path) throws IOException {
final VolumeManager fs = context.getVolumeManager();
if (!isUsingTrash()) {
+ log.trace("Accumulo Trash is disabled.");
Review Comment:
Implemented in 2aa689f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
