dtspence commented on issue #3368:
URL: https://github.com/apache/accumulo/issues/3368#issuecomment-1571292545

   Attempted to replicate with an integration test using MiniAccumulo cluster. 
Additionally reviewed source related to tablet assignment after t-server 
shutdown initiated. There may be a change between `1.10` and `2.1.1` in the 
`TabletGroupWatcher` that impacted the t-servers sent to the balancer for 
assignment.
   
   The list of servers being shutdown is used by the `TabletGroupWatcher` to 
create a list of `destinations`:
   
https://github.com/apache/accumulo/blob/2.1/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L159
   
   The `flushChanges()` method attempts to get assignments from the balancer. 
The t-server set is the current list (which includes the list of t-servers 
being shutdown).
   
https://github.com/apache/accumulo/blob/2.1/server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java#L910
   
   In previous versions (i.e. v1.10) the list passed to `flushChanges()` 
appears to have been the `destinations` which may have excluded the t-servers 
being shutdown. 
   
https://github.com/apache/accumulo/blob/1.10/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java#L214
   
https://github.com/apache/accumulo/blob/1.10/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java#L361
   
https://github.com/apache/accumulo/blob/1.10/server/master/src/main/java/org/apache/accumulo/master/TabletGroupWatcher.java#L875
   
   Continuing to investigate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to