ctubbsii commented on PR #3405: URL: https://github.com/apache/accumulo/pull/3405#issuecomment-1572962874
> > These non-thrift Java code will need review as we make progress on this. It's tedious to migrate the code, and tedious to review. I don't see any automated way around it.... unfortunately. > > Ok. The reason I was asking was because if some automated process was being used I would rather review that process than the actual changes. The only thing I can think for automating this is something like the following. > > 1. In IDE before regenerating the thrift type, for each variable in the thrift type refactor the variable in the thrift code to use getters and setters. > 2. Regenerate the thrift code w/ getters and setters for the type changed above. > 3. See if it compiles. That might be possible. I'm not sure if there's an easy way to find/replace these with getters/setters, and a lot of it requires manual intervention anyway (use of getListSize() instead of getList().size() or using the variable type as boolean to use "is" instead of "get", and primitive setters can't use increment, and verifying that null values is the same as "is not set" instead of "is set to null"). It's probably safer to review each compilation failure on a case-by-case basis and fix each one manually, than to try an automated procedure that's going to miss things. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
