dlmarion commented on code in PR #3447:
URL: https://github.com/apache/accumulo/pull/3447#discussion_r1218476866
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletManagementScanner.java:
##########
@@ -46,9 +47,11 @@ public class TabletManagementScanner implements
ClosableIterator<TabletManagemen
private final BatchScanner mdScanner;
private final Iterator<Entry<Key,Value>> iter;
private final AtomicBoolean closed = new AtomicBoolean(false);
+ private final ConcurrentLinkedQueue<TabletManagement>
knownTabletModifications;
- TabletManagementScanner(ClientContext context, Range range, CurrentState
state,
- String tableName) {
+ // This constructor is called from TabletStateStore implementations
+ public TabletManagementScanner(ClientContext context, Range range,
CurrentState state,
+ String tableName, ConcurrentLinkedQueue<TabletManagement>
knownTabletModifications) {
Review Comment:
> but I think both priority and avoiding unneeded scanning of the entire
metadata table are both good goals.
I think addressing both goals might require two different queues. The
current one which injects TabletMetadata for things that are a priority. And a
second one for tablets that are not a priority, but just known to need
attention. One of the issues that I saw while working on 78ac136 is that the
Manager might not have everything it needs to create the TabletMetadata object,
so it ends up scanning the metadata table anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
