dlmarion commented on code in PR #3482:
URL: https://github.com/apache/accumulo/pull/3482#discussion_r1226777128


##########
server/base/src/main/java/org/apache/accumulo/server/metadata/TabletMutatorBase.java:
##########
@@ -170,15 +170,15 @@ protected String getLocationFamily(LocationType type) {
   @Override
   public T putLocation(Location location) {
     Preconditions.checkState(updatesEnabled, "Cannot make updates after 
calling mutate.");
-    mutation.put(getLocationFamily(location.getType()), location.getSession(),
-        location.getHostPort());
+    mutation.put(getLocationFamily(location.getType()), "",
+        location.getServerInstance().toString());

Review Comment:
   This may be one of the biggest changes in this PR. It removes the sessionId 
from the ColQ of the location columns in the metadata and puts the 
`<host:port>#<sessionId>#<resourceGroup>` in the Value. I was wondering why the 
sessionId was in the colq to begin with, that seems like it would allow more 
than one entry for the location type in the metadata table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to