ctubbsii commented on code in PR #3481:
URL: https://github.com/apache/accumulo/pull/3481#discussion_r1227214424
##########
test/src/main/java/org/apache/accumulo/test/start/KeywordStartIT.java:
##########
@@ -203,10 +208,41 @@ public void checkHasMain() {
expectSet.add(TabletServer.class);
expectSet.add(ZooKeeperMain.class);
+ expectSet.add(ConvertConfig.class);
+ expectSet.add(ConfigPropertyUpgrader.class);
+ expectSet.add(CheckServerConfig.class);
+ expectSet.add(CreateEmpty.class);
+ expectSet.add(ECAdmin.class);
+ expectSet.add(GenerateSplits.class);
+ expectSet.add(SplitLarge.class);
+ expectSet.add(ZooZap.class);
+
+ // check that classes in the expected set contain a main
for (Class<?> c : expectSet) {
assertTrue(hasMain(c), "Class " + c.getName() + " is missing a main
method!");
}
+ // build a list of all classed that implement KeywordExecutable
+ TreeMap<String,KeywordExecutable> foundExecutables =
+ new TreeMap<>(Main.getExecutables(getClass().getClassLoader()));
Review Comment:
My suggestion can be done for 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
