cshannon commented on PR #3509: URL: https://github.com/apache/accumulo/pull/3509#issuecomment-1599685364
No surprise that the change here is not quite as fast as not doing validation altogether as shown in #3501 and #3502 but it's still a very nice improvement. I haven't had a chance yet to actually go through the validation changes itself to verify it's correct but assuming the updated validation logic looks good we could incorporate a combination of both. I think the following might be a good combination to do: 1. Make sure we validate file metadata on insertion/updates in MetadataConstraints. This is the work that is being done with #3504 and #3505. The validation done here could still be switched to using a more optimized version in the constructor (the change in this PR) to make it faster when we do need to validate and we need to eagerly load the TabletFile. 2. Avoid validating when we don't need to. This would mostly be the case when we have existing files already in metadata so when reading it should have been validated when it was inserted/updated (assuming we do number 1). This is the work that is part of #3502 and #3501. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
