cshannon commented on code in PR #3480:
URL: https://github.com/apache/accumulo/pull/3480#discussion_r1239785731
##########
core/src/main/java/org/apache/accumulo/core/metadata/AbstractTabletFile.java:
##########
@@ -62,4 +62,17 @@ public Range getRange() {
public boolean hasRange() {
return !range.isInfiniteStartKey() || !range.isInfiniteStopKey();
}
+
+ /**
+ * Return the exact string (full Json with range) that is stored in the
metadata table.
+ */
+ public abstract String getMetadata();
Review Comment:
I had added it as ReferencedTabletFile needs metadata for inserts but it
doesn't really make sense to put it there as shown by the Unsupported
operations in UnreferencedTabletFile. I will remove it and if
ReferencedTabletFile is doing an insert it will just create a StoredTabletFile
and delegate like it has before. I think it makes sense to remove the delgation
methods from ReferencedTabletFile so it's explicit what we are doing and only
StoredTabletFile object handles metadata.
##########
core/src/main/java/org/apache/accumulo/core/metadata/AbstractTabletFile.java:
##########
@@ -62,4 +62,17 @@ public Range getRange() {
public boolean hasRange() {
return !range.isInfiniteStartKey() || !range.isInfiniteStopKey();
}
+
+ /**
+ * Return the exact string (full Json with range) that is stored in the
metadata table.
+ */
+ public abstract String getMetadata();
Review Comment:
I had added it as ReferencedTabletFile needs metadata for inserts but it
doesn't really make sense to put it there as shown by the Unsupported
operations in UnreferencedTabletFile. I will remove it and if
ReferencedTabletFile is doing an insert it will just create a StoredTabletFile
and delegate like it has before. I think it makes sense to remove the
delegation methods from ReferencedTabletFile so it's explicit what we are doing
and only StoredTabletFile object handles metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
