keith-turner commented on code in PR #3533: URL: https://github.com/apache/accumulo/pull/3533#discussion_r1240146803
########## minicluster/src/main/java/org/apache/accumulo/miniclusterImpl/ClusterServerConfiguration.java: ########## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.miniclusterImpl; + +import java.util.Collections; +import java.util.HashMap; +import java.util.Iterator; +import java.util.Map; + +import org.apache.accumulo.core.lock.ServiceLockData; + +public class ClusterServerConfiguration { Review Comment: This class will need to move to the public API or the public API will need something similar. Also thinking it would be nice to make the class immutable, this could be done with a builder. ```java class ClusterServerConfiguration { static class Builder { private Map<String,Integer> compactors = COMPACTORS_DEFAULT; private Map<String,Integer> sservers = SSERVERS_DEFAULT; private Map<String,Integer> tservers = TSERVERS_DEFAULT; Builder setScanServers(Map<String,Integer> scanServerGroups, boolean appendDefautls){ if(!appendDefaults){ sservers = Map.copyOf(scanServerGroups); } else { var copy = new HashMap(scanServerGroups); copy.putAll(SSERVERS_DEFAULT); // make it immutable sservers = Map.copyOf(copy); } return this; } Builder setTabletServers(Map<String,Integer> tabletServerGroups, boolean appendDefautls){ //TODO } Builder setCompactors(Map<String,Integer> compactorGroups, boolean appendDefautls){ // TODO } ClusterServerConfiguration build(){ // this could be a private constructor return new ClusterServerConfiguration(tservers, sservers, compactors); } } static Builder builder() { return new Builder();} } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
