ctubbsii commented on PR #3511:
URL: https://github.com/apache/accumulo/pull/3511#issuecomment-1604805886

   > Before I continue on with any more updates should I go ahead and close 
this for now? The validation breaks some tests and @ctubbsii voiced concerns 
about doing this. Based on all the test failures I'm seeing and the issues 
@ctubbsii mentioned i'm hesitant to make this change now.
   
   I'm slightly opposed to this change (`-0`) for the reasons I mentioned, but 
I'm more interested in why those tests are failing. It seems this method might 
be expecting to receive full paths to files, not just the file part, as this PR 
had assumed. It's either that, or those tests are providing bad test cases, 
that this PR unintentionally caught.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to