ctubbsii commented on PR #3531: URL: https://github.com/apache/accumulo/pull/3531#issuecomment-1604974185
> Was there an issue with the previous implementation that this fixes? Nope. It just seems cleaner this way. I think it's less cumbersome to use like this. It's certainly shorter in the calling code. It was also slightly fewer lines to implement, except for the few lines I added to checkstyle to enforce the import style. > It looks like you just changed the name of the class and used a Supplier, but they are functionally equivalent. Yep! > Are there other Singletons in the code that could be placed in this new class now? I couldn't immediately think of one, and didn't seek any out, but this change creates a nice foundation for adding them if we find any. The one I did previously think of was stuff pertaining to tracing with HTrace4, but we no longer use HTrace, so that's moot. Maybe SecureRandom? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
