ctubbsii commented on code in PR #3550:
URL: https://github.com/apache/accumulo/pull/3550#discussion_r1245652005


##########
.github/workflows/maven.yaml:
##########
@@ -70,7 +70,7 @@ jobs:
         profile:
           - {name: 'unit-tests',    javaver: 11, args: 'verify -PskipQA 
-DskipTests=false'}
           - {name: 'qa-checks',     javaver: 11, args: 'verify javadoc:jar 
-Psec-bugs -DskipTests -Dspotbugs.timeout=3600000'}
-          - {name: 'compat',        javaver: 11, args: 'package -DskipTests 
-Dhadoop.version=3.0.3 -Dzookeeper.version=3.5.10'}
+          - {name: 'compat',        javaver: 11, args: 'package -DskipTests 
-Dversion.hadoop=3.0.3 -Dversion.zookeeper=3.5.10'}

Review Comment:
   We have not yet made any changes that require 3.3, so 3.0 still works and is 
supported. We can change that at some point, but that's out of scope of this 
PR. This build check is mostly to detect if/when we make such an incompatible 
change. If/when that happens, we can make a decision then, but the check should 
stay as it is for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to