keith-turner commented on code in PR #3555:
URL: https://github.com/apache/accumulo/pull/3555#discussion_r1248028947
##########
test/src/main/java/org/apache/accumulo/test/functional/CompactionIT.java:
##########
@@ -280,6 +283,28 @@ public void testUserCompactionCancellation() throws
Exception {
}
}
+ @Test
+ public void testErrorDuringUserCompaction() throws Exception {
+ final String table1 = this.getUniqueNames(1)[0];
+ try (AccumuloClient client =
Accumulo.newClient().from(getClientProps()).build()) {
+ client.tableOperations().create(table1);
+ try (BatchWriter bw = client.createBatchWriter(table1)) {
+ for (int i = 1; i <= MAX_DATA; i++) {
+ Mutation m = new Mutation(Integer.toString(i));
+ m.put("cf", "cq", new Value());
+ bw.addMutation(m);
+ bw.flush();
+ // flush often to create multiple files to compact
+ client.tableOperations().flush(table1, null, null, true);
+ }
+ }
+ IteratorSetting setting = new IteratorSetting(50, "error",
ErrorThrowingIterator.class);
+ setting.addOption(ErrorThrowingIterator.TIMES, "3");
+ client.tableOperations().attachIterator(table1, setting,
EnumSet.of(IteratorScope.majc));
+ client.tableOperations().compact(table1, new
CompactionConfig().setWait(true));
Review Comment:
Would be good to read the data in the table after compaction. Think it
would be good to run this test twice with an additional iterator. Run the test
with an additional iterator that filters a subset of data and after the
compaction verify it was filtered. Run the test another time with an
additional iterator that filters all data and verify the scan is empty and the
tablet has no files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
