keith-turner commented on code in PR #3586:
URL: https://github.com/apache/accumulo/pull/3586#discussion_r1260076824
##########
server/base/src/main/java/org/apache/accumulo/server/ServiceEnvironmentImpl.java:
##########
@@ -47,8 +44,7 @@ public Configuration getConfiguration() {
@Override
public Configuration getConfiguration(TableId tableId) {
- return tableConfigs.computeIfAbsent(tableId,
- tid -> new ConfigurationImpl(context.getTableConfiguration(tid)));
+ return new ConfigurationImpl(context.getTableConfiguration(tableId));
Review Comment:
With the changes in #3588 I think it may be good to keep the map. However
this map could be harmful in the case of a long lived plugin (like the
balancer) that is going through lots of tables. When tables are deleted this
map would keep junk around. So wondering if the map should be replaced with a
caffine cache that expires unused entries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
