EdColeman commented on PR #3600:
URL: https://github.com/apache/accumulo/pull/3600#issuecomment-1633331457
Keith asked: `What are the implication of this change in a bug fix release`
I feel that the "bug" is that incorrect naming / naming hierarchy could
complicate or prevent metrics from being used correctly down-stream. Getting
the metric correct in a 2.x release should be a priority because it is a LTM
release and we expect that it will be used for quite a while.
And the approach may hinge on if metric names are considered part of the
public API. Providing a mapping of prev -> new name in the release notes may
be sufficient if the metrics are not a "hard" API requirement.
If there is a more strict interpretation of metrics names must consistent
across bug-fix versions, the we may want to consider 2.1.2 is released as 2.2
But not sure what that implies as far as LTM designations go. We'd probably not
what to maintain 2.1 and 2.2, 3.x.,,
I can see both viewpoints. Having metric names change between versions is
irritating and could cause issues as monitors / alarms break or change with the
version, and could make trending across versions problematic. On the other
hand, having a broken metric so that I cannot monitor my system as intended
and I can't get it fixed until the next major release does not seem ideal
either,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
