dlmarion commented on code in PR #3631:
URL: https://github.com/apache/accumulo/pull/3631#discussion_r1267907393
##########
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java:
##########
@@ -159,10 +159,9 @@ public void testGetBatchWriterConfigNotUsingDefaults() {
.getMemoryAsBytes(ClientProperty.BATCH_WRITER_MEMORY_MAX.getValue(props));
assertEquals(expectedMemory, batchWriterConfig.getMaxMemory());
- assertEquals(Long.MAX_VALUE,
batchWriterConfig.getMaxLatency(MILLISECONDS));
+ assertEquals(40, batchWriterConfig.getMaxLatency(SECONDS));
Review Comment:
Shouldn't the units here be milliseconds?
##########
core/src/test/java/org/apache/accumulo/core/clientImpl/ClientContextTest.java:
##########
@@ -159,10 +159,9 @@ public void testGetBatchWriterConfigNotUsingDefaults() {
.getMemoryAsBytes(ClientProperty.BATCH_WRITER_MEMORY_MAX.getValue(props));
assertEquals(expectedMemory, batchWriterConfig.getMaxMemory());
- assertEquals(Long.MAX_VALUE,
batchWriterConfig.getMaxLatency(MILLISECONDS));
+ assertEquals(40, batchWriterConfig.getMaxLatency(SECONDS));
- // getTimeout returns time in milliseconds, therefore the 15 becomes 15000.
- assertEquals(15000, batchWriterConfig.getTimeout(SECONDS));
+ assertEquals(15, batchWriterConfig.getTimeout(SECONDS));
Review Comment:
Shouldn't the units here be milliseconds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
