ddanielr commented on code in PR #3551:
URL: https://github.com/apache/accumulo/pull/3551#discussion_r1268663900
##########
core/src/main/java/org/apache/accumulo/core/metrics/MetricsUtil.java:
##########
@@ -121,6 +121,15 @@ public static List<Tag> getCommonTags() {
return commonTags;
}
+ // Centralize any specific string formatting for metric names and/or tags.
Review Comment:
Switched the label names to use dot notation and follow micrometer
standards.
#3600 is open for the other metrics in MetricsProducer that use the `_`
separator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
