keith-turner commented on code in PR #3639: URL: https://github.com/apache/accumulo/pull/3639#discussion_r1269926881
########## test/src/main/java/org/apache/accumulo/test/ScanConsistencyIT.java: ########## @@ -0,0 +1,492 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.test; + +import static org.apache.accumulo.harness.AccumuloITBase.SUNNY_DAY; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertTrue; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Queue; +import java.util.Random; +import java.util.TreeSet; +import java.util.concurrent.Callable; +import java.util.concurrent.ConcurrentLinkedQueue; +import java.util.concurrent.Executors; +import java.util.concurrent.Future; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicLong; +import java.util.stream.Stream; + +import org.apache.accumulo.core.client.Accumulo; +import org.apache.accumulo.core.client.AccumuloClient; +import org.apache.accumulo.core.client.IsolatedScanner; +import org.apache.accumulo.core.client.Scanner; +import org.apache.accumulo.core.client.admin.CompactionConfig; +import org.apache.accumulo.core.data.Key; +import org.apache.accumulo.core.data.Mutation; +import org.apache.accumulo.core.data.Range; +import org.apache.accumulo.core.data.Value; +import org.apache.accumulo.harness.AccumuloClusterHarness; +import org.apache.hadoop.io.Text; +import org.junit.jupiter.api.Tag; +import org.junit.jupiter.api.Test; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import com.google.common.base.Preconditions; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + +/** + * This test verifies that scans will always see data written before the scan started even when + * there are concurrent scans, writes, and table operations running. + */ +@Tag(SUNNY_DAY) +public class ScanConsistencyIT extends AccumuloClusterHarness { + + private static final Logger log = LoggerFactory.getLogger(ScanConsistencyIT.class); + + @SuppressFBWarnings(value = {"PREDICTABLE_RANDOM", "DMI_RANDOM_USED_ONLY_ONCE"}, + justification = "predictable random is ok for testing") + @Test + public void testConcurrentScanConsistency() throws Exception { + final String table = this.getUniqueNames(1)[0]; + + var executor = Executors.newCachedThreadPool(); + try (AccumuloClient client = Accumulo.newClient().from(getClientProps()).build()) { + client.tableOperations().create(table); + + TestContext testContext = new TestContext(client, table); + + List<Future<WriteStats>> writeTasks = new ArrayList<>(); + List<Future<ScanStats>> scanTasks = new ArrayList<>(); + + Random random = new Random(); + + int numWriteTask = random.nextInt(10) + 1; + int numsScanTask = random.nextInt(10) + 1; + + for (int i = 0; i < numWriteTask; i++) { + writeTasks.add(executor.submit(new WriteTask(testContext))); + } + + for (int i = 0; i < numsScanTask; i++) { + scanTasks.add(executor.submit(new ScanTask(testContext))); + } + + var tableOpsTask = executor.submit(new TableOpsTask(testContext)); + + // let the concurrent mayhem run for a bit + Thread.sleep(60000); Review Comment: Yeah I think there is value in running it longer, but maybe not in the IT. We definitely want to know if does not work on a short run. I think I will add a main method that allows running it. I think it would be good to have as an IT and something that is easy to run for longer periods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
