dlmarion commented on code in PR #3629:
URL: https://github.com/apache/accumulo/pull/3629#discussion_r1272515606
##########
core/src/main/java/org/apache/accumulo/core/util/cache/Caches.java:
##########
@@ -75,22 +78,26 @@ public void registerMetrics(MeterRegistry registry) {
this.registry = registry;
}
- private void setupMicrometerMetrics(Caffeine<Object,Object> cacheBuilder,
String name) {
+ private boolean setupMicrometerMetrics(Caffeine<Object,Object> cacheBuilder,
String name) {
if (registry != null) {
try {
cacheBuilder.recordStats(
() -> new CaffeineStatsCounter(registry, name,
MetricsUtil.getCommonTags()));
+ return true;
} catch (IllegalStateException e) {
// recordStats was already called by the cacheBuilder.
Review Comment:
Logging added in 8bee224.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
