ctubbsii commented on code in PR #3562:
URL: https://github.com/apache/accumulo/pull/3562#discussion_r1274149466
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateNamespaceCommand.java:
##########
@@ -32,42 +32,55 @@
import org.apache.accumulo.shell.Shell.Command;
import org.apache.commons.cli.CommandLine;
import org.apache.commons.cli.Option;
-import org.apache.commons.cli.OptionGroup;
import org.apache.commons.cli.Options;
public class CreateNamespaceCommand extends Command {
private Option createNamespaceOptCopyConfig;
+ private Option createNamesapceOptExcludeParentProps;
@Override
public int execute(final String fullCommand, final CommandLine cl, final
Shell shellState)
throws AccumuloException, AccumuloSecurityException,
TableExistsException,
TableNotFoundException, IOException, ClassNotFoundException,
NamespaceExistsException,
NamespaceNotFoundException {
- if (createNamespaceOptCopyConfig == null) {
- getOptions();
+ // validate that copy config and copy properties options are mutually
exclusive.
Review Comment:
This comment is out of date with the current code and refers to a previous
iteration of this change.
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateTableCommand.java:
##########
@@ -292,7 +310,9 @@ public Options getOptions() {
final Options o = new Options();
createTableOptCopyConfig =
- new Option("cc", "copy-config", true, "table to copy configuration
from");
+ new Option("cc", "copy-config", true, "table to copy effective
configuration from");
+ createTableOptExcludeParentProps = new Option(null, "exclude-parent",
false,
+ "exclude parent(s) properties when copying configuration");
Review Comment:
s/parent(s)/parent's/
##########
shell/src/main/java/org/apache/accumulo/shell/commands/CreateNamespaceCommand.java:
##########
@@ -89,10 +102,11 @@ public Options getOptions() {
new Option("cc", "copy-config", true, "namespace to copy configuration
from");
createNamespaceOptCopyConfig.setArgName("namespace");
- OptionGroup ogp = new OptionGroup();
- ogp.addOption(createNamespaceOptCopyConfig);
+ createNamesapceOptExcludeParentProps = new Option(null, "exclude-parent",
false,
+ "exclude parent(s) properties when copying configuration");
Review Comment:
s/parent(s)/parent's/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
