EdColeman commented on code in PR #3620:
URL: https://github.com/apache/accumulo/pull/3620#discussion_r1276830744
##########
server/base/src/main/java/org/apache/accumulo/server/conf/util/ZooPropEditor.java:
##########
@@ -107,6 +111,10 @@ public void execute(String[] args) throws Exception {
default:
throw new IllegalArgumentException("Invalid operation requested");
}
+ } catch (Exception ex) {
+ LOG.error("{} command failed", keyword(), ex);
+ // hard fail - set exit status
+ System.exit(-1);
Review Comment:
The point of calling system exit was so that there was an explicit error
return status - if some one were to write a script, I wanted to make sure that
had an option to test the command return. I was not sure that throwing an
exception would do that - and I wanted it to be explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
